[ 
https://issues.apache.org/jira/browse/YARN-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189576#comment-15189576
 ] 

Eric Payne commented on YARN-4686:
----------------------------------

[~ebadger], Thanks for working on a fix this issue.

The patch is causing a failure with {{TestYarnClient}}:
{code}
TestYarnClient.testReservationAPIs:1209 The size of the largest gang in the 
reservation refinition (<memory:1024, vCores:1>) exceed the capacity available 
(<memory:0, vCores:0> )
{code}

Other than that, the patch looks good to me. I am a little concerned about the 
removal of extra threads in {{MiniYARNCluster#startResourceManager}} and 
{{MiniYARNCluster#*#serviceStart}}. I would be interested in [~jlowe]'s and 
[~kasha]'s thoughts.

> MiniYARNCluster.start() returns before cluster is completely started
> --------------------------------------------------------------------
>
>                 Key: YARN-4686
>                 URL: https://issues.apache.org/jira/browse/YARN-4686
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>            Reporter: Rohith Sharma K S
>            Assignee: Eric Badger
>         Attachments: MAPREDUCE-6507.001.patch, YARN-4686.001.patch, 
> YARN-4686.002.patch, YARN-4686.003.patch
>
>
> TestRMNMInfo fails intermittently. Below is trace for the failure
> {noformat}
> testRMNMInfo(org.apache.hadoop.mapreduce.v2.TestRMNMInfo)  Time elapsed: 0.28 
> sec  <<< FAILURE!
> java.lang.AssertionError: Unexpected number of live nodes: expected:<4> but 
> was:<3>
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.failNotEquals(Assert.java:743)
>       at org.junit.Assert.assertEquals(Assert.java:118)
>       at org.junit.Assert.assertEquals(Assert.java:555)
>       at 
> org.apache.hadoop.mapreduce.v2.TestRMNMInfo.testRMNMInfo(TestRMNMInfo.java:111)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to