[
https://issues.apache.org/jira/browse/YARN-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196270#comment-15196270
]
Eric Payne commented on YARN-4686:
----------------------------------
[~ebadger], thanks for updating this patch. Just one minor nit:
In {{MiniYARNCluster#NodeManagerWrapper#serviceStart:
{code}
+ if (nodeManagers[index].getServiceState() != STATE.STARTED) {
+ // RM could have failed.
+ throw new IOException("NodeManager " + index + " failed to start");
{code}
The comment should be {{NM}} rather than {{RM}}
Otherwise, looks good to me. Still interested in if [~jlowe] or [~kasha] have
comments, especially about removal of the (extra) threads in
{{startResourceManager}} and {{serviceStart}} methods.
> MiniYARNCluster.start() returns before cluster is completely started
> --------------------------------------------------------------------
>
> Key: YARN-4686
> URL: https://issues.apache.org/jira/browse/YARN-4686
> Project: Hadoop YARN
> Issue Type: Bug
> Components: test
> Reporter: Rohith Sharma K S
> Assignee: Eric Badger
> Attachments: MAPREDUCE-6507.001.patch, YARN-4686.001.patch,
> YARN-4686.002.patch, YARN-4686.003.patch, YARN-4686.004.patch,
> YARN-4686.005.patch
>
>
> TestRMNMInfo fails intermittently. Below is trace for the failure
> {noformat}
> testRMNMInfo(org.apache.hadoop.mapreduce.v2.TestRMNMInfo) Time elapsed: 0.28
> sec <<< FAILURE!
> java.lang.AssertionError: Unexpected number of live nodes: expected:<4> but
> was:<3>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at
> org.apache.hadoop.mapreduce.v2.TestRMNMInfo.testRMNMInfo(TestRMNMInfo.java:111)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
