[ 
https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191389#comment-15191389
 ] 

Junping Du commented on YARN-998:
---------------------------------

Thanks Kenji for providing a sample patch. 
Several improvements should make over the current sample patch:
1. We should load DynamicResourceConfiguration only one time in 
ResourceTrackerService in initialization instead of load it every time NM 
register it.
2. The config will be refreshed when RMAdmin CLI - "refreshNodeResources" is 
triggered to make sure NM restart case is addressed.
3. No need to persistent individual node update CLI - "updateNodeResource" to 
dynamic resource file. If user want it get persistent, then it should update 
the dynamic resource file as long as trigger the node CLI.
4. Some duplicated code with YARN-1911 should get removed.
Will deliver an updated patch soon.

> Persistent resource change during NM/RM restart
> -----------------------------------------------
>
>                 Key: YARN-998
>                 URL: https://issues.apache.org/jira/browse/YARN-998
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: graceful, nodemanager, scheduler
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: YARN-998-sample.patch
>
>
> When NM is restarted by plan or from a failure, previous dynamic resource 
> setting should be kept for consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to