[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196541#comment-15196541 ]
Jian He commented on YARN-998: ------------------------------ thanks Junping for the explanation, few comments I have: - DynamicResourceConfiguration(configuration, true), the second parameter is not needed because it’s always passing ‘true’; - instead of reload the config again, looks like we can just call set(newConf) to replace the config? newConfig is reloaded earlier in the same call path. {code} // refresh dynamic resource in ResourceTrackerService this.rmContext.getResourceTrackerService(). loadDynamicResourceConfiguration(conf); {code} > Persistent resource change during NM/RM restart > ----------------------------------------------- > > Key: YARN-998 > URL: https://issues.apache.org/jira/browse/YARN-998 > Project: Hadoop YARN > Issue Type: Sub-task > Components: graceful, nodemanager, scheduler > Reporter: Junping Du > Assignee: Junping Du > Attachments: YARN-998-sample.patch, YARN-998-v1.patch > > > When NM is restarted by plan or from a failure, previous dynamic resource > setting should be kept for consistency. -- This message was sent by Atlassian JIRA (v6.3.4#6332)