[ 
https://issues.apache.org/jira/browse/YARN-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203840#comment-15203840
 ] 

Wangda Tan commented on YARN-4517:
----------------------------------

Thanks [~varun_saxena] working this JIRA and [~gtCarrera]/[~sunilg] for 
discussions. In general it looks good.

A couple of comments,
- Not sure why url looks like following: 
{{http://localhost:4200/yarnNode/localhost:61236/localhost:8042}}, I can 
understand last part is nodeId.toString, but why is {{localhost:61236}} added 
to URL?
- Cannot view container logs when log aggregation is disabled
- Format issue: pie chart - {{Resource - Memory (in MB)}} cannot be fully 
rendered from my browser
- 
{{hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/controllers/application.js}}
 typically we shouldn't put html directly to controller, ideally we should move 
as much as possible html code into templates. If we cannot move all of them 
into templates, component/helper should be fine with html code.
- As mentioned by [~gtCarrera], we need a unified container/application page.

Since we're trying to merge code back to trunk soon to unblock YARN-2928, I 
think it will be fine to address above comments in a separated JIRA.
To make sure we won't forget what we discussed above, could you file a ticket 
to fix above items?

> [YARN-3368] Add nodes page
> --------------------------
>
>                 Key: YARN-4517
>                 URL: https://issues.apache.org/jira/browse/YARN-4517
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Wangda Tan
>            Assignee: Varun Saxena
>              Labels: webui
>         Attachments: (21-Feb-2016)yarn-ui-screenshots.zip, 
> Screenshot_after_4709.png, Screenshot_after_4709_1.png, 
> YARN-4517-YARN-3368.01.patch, YARN-4517-YARN-3368.02.patch
>
>
> We need nodes page added to next generation web UI, similar to existing 
> RM/nodes page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to