[
https://issues.apache.org/jira/browse/YARN-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203914#comment-15203914
]
Varun Saxena commented on YARN-4517:
------------------------------------
[~leftnoteasy], thanks for the review.
bq. Not sure why url looks like following:
http://localhost:4200/yarnNode/localhost:61236/localhost:8042, I can understand
last part is nodeId.toString, but why is localhost:61236 added to URL?
NodeId is required to query node info from RM. It has been passed around
everywhere because we need to create link for left hand side menu on every page.
bq. Cannot view container logs when log aggregation is disabled
With aggregation disabled ? Are you testing with latest trunk code ? We had
issues before YARN-4709 went in.
bq.
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/controllers/application.js
typically we shouldn't put html directly to controller, ideally we should move
as much as possible html code into templates. If we cannot move all of them
into templates, component/helper should be fine with html code.
Ok. Moved this to controller to get hold of currentPath. Will move this code to
a helper or component.
bq. Format issue: pie chart - Resource - Memory (in MB) cannot be fully
rendered from my browser
Ok. Will check. Even with full(not minimized) browser window ?
> [YARN-3368] Add nodes page
> --------------------------
>
> Key: YARN-4517
> URL: https://issues.apache.org/jira/browse/YARN-4517
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Wangda Tan
> Assignee: Varun Saxena
> Labels: webui
> Attachments: (21-Feb-2016)yarn-ui-screenshots.zip,
> Screenshot_after_4709.png, Screenshot_after_4709_1.png,
> YARN-4517-YARN-3368.01.patch, YARN-4517-YARN-3368.02.patch
>
>
> We need nodes page added to next generation web UI, similar to existing
> RM/nodes page.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
