[
https://issues.apache.org/jira/browse/YARN-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213264#comment-15213264
]
Karthik Kambatla commented on YARN-2883:
----------------------------------------
Took a closer look at the patch. I am a little confused, very likely due to the
javadoc comments. More high-level comments:
# In case of guaranteed containers, {{ContainerManagerImpl}} receives and
launches the containers, and eventually handles the monitoring task to
{{ContainersMonitorImpl}}. Using {{ContainerStopMonitoringEvent}} to figure out
when to start the next queued container seems confusing. Is there no other way
around this? How about having {{ContainerImpl#sendFinishedEvents}} notify
{{ContainerManagerImpl}} so it can consider launching a queued container?
# {{ContainerManagerImpl}} starts containers synchronously, without any events.
I would expect {{QueuingContainerManagerImpl}} to queue containers the same way
- synchronously. That would save us one set of event and event-type classes.
> Queuing of container requests in the NM
> ---------------------------------------
>
> Key: YARN-2883
> URL: https://issues.apache.org/jira/browse/YARN-2883
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Konstantinos Karanasos
> Assignee: Konstantinos Karanasos
> Attachments: YARN-2883-trunk.004.patch, YARN-2883-trunk.005.patch,
> YARN-2883-trunk.006.patch, YARN-2883-yarn-2877.001.patch,
> YARN-2883-yarn-2877.002.patch, YARN-2883-yarn-2877.003.patch,
> YARN-2883-yarn-2877.004.patch
>
>
> We propose to add a queue in each NM, where queueable container requests can
> be held.
> Based on the available resources in the node and the containers in the queue,
> the NM will decide when to allow the execution of a queued container.
> In order to ensure the instantaneous start of a guaranteed-start container,
> the NM may decide to pre-empt/kill running queueable containers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
