[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220279#comment-15220279
]
Jason Lowe commented on YARN-4311:
----------------------------------
Thanks for updating the patch! Everything looks great except nodes list
should not be possessive, i.e.: "nodes' list" should just be "nodes list".
bq. I have additionally added a log line at info level when the node is removed
from the inactive list to better track when nodes finally go away. Should this
be at debug level?
I think it's fine to log it at INFO. It should be a relatively rare log
message, and it helps explain to users/admins why a node disappeared from the
RM UI.
> Removing nodes from include and exclude lists will not remove them from
> decommissioned nodes list
> -------------------------------------------------------------------------------------------------
>
> Key: YARN-4311
> URL: https://issues.apache.org/jira/browse/YARN-4311
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.6.1
> Reporter: Kuhu Shukla
> Assignee: Kuhu Shukla
> Attachments: YARN-4311-v1.patch, YARN-4311-v10.patch,
> YARN-4311-v11.patch, YARN-4311-v11.patch, YARN-4311-v12.patch,
> YARN-4311-v2.patch, YARN-4311-v3.patch, YARN-4311-v4.patch,
> YARN-4311-v5.patch, YARN-4311-v6.patch, YARN-4311-v7.patch,
> YARN-4311-v8.patch, YARN-4311-v9.patch
>
>
> In order to fully forget about a node, removing the node from include and
> exclude list is not sufficient. The RM lists it under Decomm-ed nodes. The
> tricky part that [~jlowe] pointed out was the case when include lists are not
> used, in that case we don't want the nodes to fall off if they are not active.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
