[ 
https://issues.apache.org/jira/browse/YARN-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226521#comment-15226521
 ] 

Varun Saxena commented on YARN-4514:
------------------------------------

IIUC, we expect this configuration to be configured by user during deployment. 
Right ?

If that's the case shouldn't the namespaces like ws/v1/cluster, etc. move to 
constants.js, the file I had created in YARN-4517.
I am not too sure if it be required for users to configure namespaces. These 
sound more like constants. 
Maybe the only config which they may require is whether they are connecting to 
ATSv1 or ATSv2, which I think can be added in some ATSv2 JIRA.
[~sunilg], what do you think ?

Also would we want to put config.js in a separate folder named something like 
config ? I had placed it outside(under app folder) in YARN-4517 because it was 
mainly added for convenience and we had this JIRA open too. Basically we need 
to decide where we want to keep it while packaging.

Correct me if I am wrong. I think we wont require localBaseUrl(which is 
corsproxy URL) in normal production cluster. 
So maybe we can have a separate config for scheme(http/https). And do not 
consider corsproxy URL for production. I think maybe we can use ENV.baseUrl in 
config/environment.js for this. And set ENV.baseUrl to "" for production.

> [YARN-3368] Cleanup hardcoded configurations, such as RM/ATS addresses
> ----------------------------------------------------------------------
>
>                 Key: YARN-4514
>                 URL: https://issues.apache.org/jira/browse/YARN-4514
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>         Attachments: YARN-4514-YARN-3368.1.patch, YARN-4514-YARN-3368.2.patch
>
>
> We have several configurations are hard-coded, for example, RM/ATS addresses, 
> we should make them configurable. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to