[
https://issues.apache.org/jira/browse/YARN-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232877#comment-15232877
]
Sunil G commented on YARN-4514:
-------------------------------
bq.Although it can be mentioned in config file comments but it just looks a bit
weird. I think in each of the adapter files we can put a / by ourselves.
There is one issue with this. Going forward if we are moving out from CORS,
then we can give it empty. So URL will be like below:
{{Config.envDefaults.protocolScheme + Config.envDefaults.localBaseUrl +
Config.envDefaults.rmWebURL}} which will be translated as
Config.envDefaults.protocolScheme = "http://";
Config.envDefaults.localBaseUrl = ""
Config.envDefaults.rmWebURL = "<ip>:<port>"
So URL will come correctly. If we set {{/}} by ourselves, then it will be an
extra config only for CORS proxy and we ll have issues. SO i think we can
mentioned on comment itself.
bq.Maybe name it as timelineWebAddress, rmWebAddress and so on.
Make sense to me. I will update.
For other comments, I will wait for [~leftnoteasy] take also as mentioned by
[~varun_saxena]
> [YARN-3368] Cleanup hardcoded configurations, such as RM/ATS addresses
> ----------------------------------------------------------------------
>
> Key: YARN-4514
> URL: https://issues.apache.org/jira/browse/YARN-4514
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Sunil G
> Attachments: YARN-4514-YARN-3368.1.patch,
> YARN-4514-YARN-3368.2.patch, YARN-4514-YARN-3368.3.patch,
> YARN-4514-YARN-3368.4.patch
>
>
> We have several configurations are hard-coded, for example, RM/ATS addresses,
> we should make them configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
