[
https://issues.apache.org/jira/browse/YARN-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232915#comment-15232915
]
Wangda Tan commented on YARN-4514:
----------------------------------
Sorry I pushed the change unconsciously while doing rebase, removed YARN-4514
from branch-3368 just now.
When I look at tez-ui2, their configuration file is a configs.env instead of
JS. which could be kept after build:
https://github.com/apache/tez/blob/master/tez-ui2/src/main/webapp/config/configs.env.
And it adds reference to the config file from index.html:
https://github.com/apache/tez/blob/master/tez-ui2/src/main/webapp/app/index.html
If it is possible, we should follow the pattern, otherwise the configs.js will
be appended to other JS files so we cannot modify it after packaging.
Computed value is a good idea:
https://github.com/apache/tez/blob/master/tez-ui2/src/main/webapp/app/services/hosts.js
And we may not need localBaseUrl, since it is a workaround before we fix CORS
issues in YARN.
> [YARN-3368] Cleanup hardcoded configurations, such as RM/ATS addresses
> ----------------------------------------------------------------------
>
> Key: YARN-4514
> URL: https://issues.apache.org/jira/browse/YARN-4514
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Sunil G
> Attachments: YARN-4514-YARN-3368.1.patch,
> YARN-4514-YARN-3368.2.patch, YARN-4514-YARN-3368.3.patch,
> YARN-4514-YARN-3368.4.patch
>
>
> We have several configurations are hard-coded, for example, RM/ATS addresses,
> we should make them configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
