[
https://issues.apache.org/jira/browse/YARN-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257177#comment-15257177
]
Li Lu commented on YARN-3150:
-----------------------------
Thanks [~sjlee0] for the update! Quite close, some comments on the newly added
figure and some nits:
- For the figure (timeline_v2.jpg), some questions and comments:
1. What does the white box outside the NM stand for? I'm a little bit confused
by it...
2. In the text I can see we're discussing that currently collectors are
launched as aux services inside NM. Are we planning to represent this
relationship in the figure? If not, maybe we can briefly say something to avoid
confusion on the arrow from NM to the collector.
3. IIUC, the bold arrows in the figure mean write data flow, and the solid ones
mean read request? Maybe we want a simple legend for this, or explain it in the
caption?
- For the configuration table, I think we can use bold or italic to mark new
configs? In this way we don't need a new column?
- Because the whole doc is about YARN timeline service, I think it will be
helpful to say {{mapreduce.job.emit-timeline-data}} is in mapred-site?
Other parts LGTM. I'd encourage everyone interested to take a look at it. Shall
we update the YARN-2928 JIRA for this?
> [Documentation] Documenting the timeline service v2
> ---------------------------------------------------
>
> Key: YARN-3150
> URL: https://issues.apache.org/jira/browse/YARN-3150
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Sangjin Lee
> Labels: yarn-2928-1st-milestone
> Attachments: TimelineServiceV2.html, YARN-3150-YARN-2928.01.patch,
> YARN-3150-YARN-2928.02.patch
>
>
> Let's make sure we will have a document to describe what's new in TS v2, the
> APIs, the client libs and so on. We should do better around documentation in
> v2 than v1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
