[
https://issues.apache.org/jira/browse/YARN-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257361#comment-15257361
]
Sangjin Lee commented on YARN-3150:
-----------------------------------
Thanks [~gtCarrera9] for your review. I hope the latest version addresses most
of them. Please note that this is still not final. We're still looking into the
steps for loading the coprocessor. I'll update the doc when we have the
contents ready for that.
bq. 1. What does the white box outside the NM stand for? I'm a little bit
confused by it...
Do you mean the stack of boxes? It is a way to indicate "multiple worker nodes".
bq. 2. In the text I can see we're discussing that currently collectors are
launched as aux services inside NM. Are we planning to represent this
relationship in the figure? If not, maybe we can briefly say something to avoid
confusion on the arrow from NM to the collector.
I added more captions to indicate that the timeline collector is on the node
that's running the AM, and other (remote) NMs can write to that timeline
collector. Hopefully the captions make it clearer. I also added a few sentences
that describe that.
bq. 3. IIUC, the bold arrows in the figure mean write data flow, and the solid
ones mean read request? Maybe we want a simple legend for this, or explain it
in the caption?
Good suggestion. I made that change.
bq. For the configuration table, I think we can use bold or italic to mark new
configs? In this way we don't need a new column?
Another good suggestion. I made that change too.
bq. Because the whole doc is about YARN timeline service, I think it will be
helpful to say mapreduce.job.emit-timeline-data is in mapred-site?
I added that that property should be in {{mapred-site.xml}}.
bq. Shall we update the YARN-2928 JIRA for this?
I wasn't 100% sure what you meant by this. Did you mean we should update the
description, add a comment, or?
> [Documentation] Documenting the timeline service v2
> ---------------------------------------------------
>
> Key: YARN-3150
> URL: https://issues.apache.org/jira/browse/YARN-3150
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Sangjin Lee
> Labels: yarn-2928-1st-milestone
> Attachments: TimelineServiceV2.html, YARN-3150-YARN-2928.01.patch,
> YARN-3150-YARN-2928.02.patch, YARN-3150-YARN-2928.03.patch
>
>
> Let's make sure we will have a document to describe what's new in TS v2, the
> APIs, the client libs and so on. We should do better around documentation in
> v2 than v1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
