[
https://issues.apache.org/jira/browse/YARN-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279402#comment-15279402
]
Kai Sasaki commented on YARN-4996:
----------------------------------
[~templedf] Thanks for checking. I updated it to use
{{ParameterizedSchedulerTestBase}}.
{quote}
Why the additional code in testRMNodeStatusAfterReconnect()?
{quote}
This was necessary to run test for both schedulers(FairScheduler and
CapacityScheduler) in one test suite because it causes inconsistent state
between queue and metrics system. But currently only default scheduler test run
with {{ParameterizedSchedulerTestBase}}, so I could remove it.
> Make TestNMReconnect.testCompareRMNodeAfterReconnect() scheduler agnostic, or
> better yet parameterized
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-4996
> URL: https://issues.apache.org/jira/browse/YARN-4996
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager, test
> Affects Versions: 2.8.0
> Reporter: Daniel Templeton
> Assignee: Kai Sasaki
> Priority: Minor
> Labels: newbie
> Attachments: YARN-4996.01.patch, YARN-4996.02.patch,
> YARN-4996.03.patch
>
>
> The test tests only the capacity scheduler. It should also test fair
> scheduler. At a bare minimum, it should use the default scheduler.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
