[
https://issues.apache.org/jira/browse/YARN-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282763#comment-15282763
]
Junping Du commented on YARN-4832:
----------------------------------
Thanks for review and comments, Jian!
bq. I'm thinking of a simpler implementation is to let RM keep on sending the
resource to NM, thus avoiding the new timeout logic in ResourceTrackerService.
The extra data sent is only the Resource object, which should be fairly small.
Okay. Let's keep it simple so far just like your mentioned reason.
bq. Adding the same field in NM RegistrationResponse does not make much
difference, but that we have a new field to maintain.
I didn't see maintaining a new field is a problem. I hope we can get back the
right NM resource value as soon as possible. If NM lost connection after
register (due to RM restart or some other reason), then NM will have incorrect
value in its metrics for a longer time. So I think it is better to have
registration response with adjusted resource. What do you think?
I will incorporate your first comment in next patch.
> NM side resource value should get updated if change applied in RM side
> ----------------------------------------------------------------------
>
> Key: YARN-4832
> URL: https://issues.apache.org/jira/browse/YARN-4832
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Junping Du
> Assignee: Junping Du
> Priority: Critical
> Attachments: YARN-4832-demo.patch, YARN-4832.patch
>
>
> Now, if we execute CLI to update node (single or multiple) resource in RM
> side, NM will not receive any notification. It doesn't affect resource
> scheduling but will make resource usage metrics reported by NM a bit weird.
> We should sync up new resource between RM and NM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
