[
https://issues.apache.org/jira/browse/YARN-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283930#comment-15283930
]
Arun Suresh commented on YARN-4830:
-----------------------------------
Thanks for working on this [~vvasudev].. and apologize for the delay in
feedback.
The patch itself looks mostly good. Few comments :
* Do we need *LOG* in ResourcePBImpl ? or is it just for testing ?
* ResourceUtils::addResourcesFileToConf : add a finally to close the input
stream
* check/addMandatoryResourceTypes : My opinion is we should keep it as
check/addMandatoryResources since we are actually adding the resource values.
The Type in to name means we are adding a new type of resource
* Can’t {{nodeLock}} be replaced with a volatile boolean ?
* Thinking if we really need {{nodeLock}} at all.. can’t we perform the null
check and synchronized assignment on {{readOnlyNodeResources}} itself ? or am I
missing something ?
> Add support for resource types in the nodemanager
> -------------------------------------------------
>
> Key: YARN-4830
> URL: https://issues.apache.org/jira/browse/YARN-4830
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-4830-YARN-3926.001.patch,
> YARN-4830-YARN-3926.002.patch
>
>
> The RM has support for multiple resource types. The same should be added for
> the NMs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
