[
https://issues.apache.org/jira/browse/YARN-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286078#comment-15286078
]
Arun Suresh commented on YARN-5075:
-----------------------------------
Pasting the result of locally running testpatch
{noformat}
-1 overall
_____ _ _ _
| ___|_ _(_) |_ _ _ __ ___| |
| |_ / _` | | | | | | '__/ _ \ |
| _| (_| | | | |_| | | | __/_|
|_| \__,_|_|_|\__,_|_| \___(_)
| Vote | Subsystem | Runtime | Comment
============================================================================
| +1 | @author | 0m 00s | The patch does not contain any @author
| | | | tags.
| -1 | test4tests | 0m 00s | The patch doesn't appear to include any
| | | | new or modified tests. Please justify why
| | | | no new tests are needed for this patch.
| | | | Also please list what manual steps were
| | | | performed to verify this patch.
| 0 | mvndep | 0m 08s | Maven dependency ordering for branch
| +1 | mvninstall | 3m 57s | trunk passed
| +1 | compile | 1m 13s | trunk passed
| +1 | checkstyle | 0m 33s | trunk passed
| +1 | mvnsite | 2m 40s | trunk passed
| +1 | mvneclipse | 0m 58s | trunk passed
| 0 | findbugs | 0m 00s | Skipped branch modules with no Java
| | | | source: hadoop-yarn-project/hadoop-yarn
| 0 | findbugs | 0m 24s |
| | | |
hadoop-yarn-project/hadoop-yarn/hadoop-yar
| | | | n-server/hadoop-yarn-server-common in
| | | | trunk has 3 extant Findbugs warnings.
| +1 | javadoc | 2m 21s | trunk passed
| 0 | mvndep | 0m 07s | Maven dependency ordering for patch
| +1 | mvninstall | 2m 06s | the patch passed
| +1 | compile | 1m 17s | the patch passed
| +1 | javac | 1m 17s | the patch passed
| +1 | checkstyle | 0m 29s | hadoop-yarn-project/hadoop-yarn: patch
| | | | generated 0 new + 258 unchanged - 7 fixed
| | | | = 258 total (was 265)
| +1 | mvnsite | 2m 41s | the patch passed
| +1 | mvneclipse | 0m 43s | the patch passed
| +1 | whitespace | 0m 00s | Patch has no whitespace issues.
| +1 | xml | 0m 01s | The patch has no ill-formed XML file.
| 0 | findbugs | 0m 00s | Skipped patch modules with no Java
| | | | source: hadoop-yarn-project/hadoop-yarn
| +1 | findbugs | 0m 43s | hadoop-yarn-api in the patch passed.
| +1 | findbugs | 0m 27s |
| | | |
hadoop-yarn-project/hadoop-yarn/hadoop-yar
| | | | n-server/hadoop-yarn-server-common
| | | | generated 0 new + 0 unchanged - 3 fixed =
| | | | 0 total (was 3)
| +1 | findbugs | 0m 41s | hadoop-yarn-server-resourcemanager in
| | | | the patch passed.
| +1 | javadoc | 2m 10s | the patch passed
| +1 | asflicense | 0m 16s | Patch does not generate ASF License
| | | | warnings.
| | | 26m 03s |
|| Subsystem || Report/Notes ||
============================================================================
| Optional Tests | asflicense findbugs xml compile javac javadoc
mvninstall mvnsite unit checkstyle |
| uname | Darwin enceladus-mbp 14.5.0 Darwin Kernel Version 14.5.0: Wed Jul 29
02:26:53 PDT 2015; root:xnu-2782.40.9~1/RELEASE_X86_64 x86_64 |
| Build tool | maven |
| Personality |
/Users/asuresh/stuff/apache/hadoop/patchprocess/yetus-0.2.0/lib/precommit/personality/hadoop.sh
|
| git revision | trunk / 2c91fd8 |
| Default Java | 1.8.0_66 |
| findbugs | v3.0.0 |
| modules | C: hadoop-yarn-project/hadoop-yarn
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
U: hadoop-yarn-project/hadoop-yarn |
| Powered by | Apache Yetus 0.2.0 http://yetus.apache.org |
============================================================================
============================================================================
Finished build.
============================================================================
============================================================================
{noformat}
Please note the fixed findbugs note :
{noformat}
|+1 | findbugs | 0m 27s |
| | | | hadoop-yarn-project/hadoop-yarn/hadoop-yar
| | | | n-server/hadoop-yarn-server-common
| | | | generated 0 new + 0 unchanged - 3 fixed =
| | | | 0 total (was 3)
{noformat}
And the fixed checkstyle :
{noformat}
| +1 | checkstyle | 0m 29s | hadoop-yarn-project/hadoop-yarn: patch
| | | | generated 0 new + 258 unchanged - 7 fixed
| | | | = 258 total (was 265)
{noformat}
> Fix findbugs warning in hadoop-yarn-common module
> -------------------------------------------------
>
> Key: YARN-5075
> URL: https://issues.apache.org/jira/browse/YARN-5075
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Akira AJISAKA
> Assignee: Arun Suresh
> Attachments: YARN-5075.001.patch, YARN-5075.002.patch, findbugs.html
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
