[
https://issues.apache.org/jira/browse/YARN-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311509#comment-15311509
]
Joep Rottinghuis commented on YARN-5189:
----------------------------------------
Thanks for review Sangjin.
Will upload patch with your comments 1), 2) and 4) addressed shortly.
I noticed that on our branch (before and after my patch) the distributed shell
doesn't compile cleanly with a mvn clean package unless I first do a mvn
install on the timelineservice project, but perhaps that's because I'm mixing
testing between a repo with my patch in it and one that has a clean YARN-2928
branch checked out.
Wrt. (3) I have two questions:
a) Do you mean we should actually have the name of the Impl class in
YarnConfiguration.java or just a property in yarn-default that matches the
property names as defined in YarnConfiguration.java? Right now the defaulting
is happening in TimelineCollectorManager#serviceInit:
{code}
writer = ReflectionUtils.newInstance(conf.getClass(
YarnConfiguration.TIMELINE_SERVICE_WRITER_CLASS,
HBaseTimelineWriterImpl.class,
TimelineWriter.class), conf);
writer.init(conf);
{code}
and TimelineReaderServer#createTimelineReaderStore:
{code}
TimelineReader readerStore = ReflectionUtils.newInstance(conf.getClass(
YarnConfiguration.TIMELINE_SERVICE_READER_CLASS,
HBaseTimelineReaderImpl.class, TimelineReader.class), conf);
{code}
b) Shall we keep a config in YarnConfiguration that is now used only for
testing, or shall we get rid of this config?
{code}
// This is temporary solution. The configuration will be deleted once we have
// the FileSystem API to check whether append operation is supported or not.
public static final String TIMELINE_SERVICE_ENTITYFILE_FS_SUPPORT_APPEND
= TIMELINE_SERVICE_PREFIX
+ "entity-file.fs-support-append";
{code}
If we want to keep it I think I should add a comment that this is used only for
the test file-based implementations right?
> Make HBaseTimeline[Reader|Writer]Impl default and move FileSystemTimeline*Impl
> ------------------------------------------------------------------------------
>
> Key: YARN-5189
> URL: https://issues.apache.org/jira/browse/YARN-5189
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-5189-YARN-2928.01.patch
>
>
> [~naganarasimha...@apache.org] questioned whether it made sense to default to
> an implementation that doesn't support all functionality.
> [~sjlee0] opened YARN-5174 to track updating the documentation for ATS to
> reflect the default shifting to the fully functional HBase implementation.
> It makes sense to remove a partial implementation, but on the other hand it
> is still handing in testing. Hence this jira to move the file based
> implementations to the test package and to make the HBase impls the default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
