[
https://issues.apache.org/jira/browse/YARN-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313387#comment-15313387
]
Sangjin Lee commented on YARN-5189:
-----------------------------------
I see 2 unit tests switching over from filesystem to hbase, but they seem to be
fine (don't have logic of looking at directories to verify test results). I am
inclined to leaving them that way:
{noformat}
TestResourceTrackerService#testNodeHeartbeatForAppCollectorsMap
TestRMRestart#testRMRestartTimelineCollectorContext
{noformat}
{quote}
For here, my only concern is that, seems like we're creating a lot of
YarnConfigurations and modify the TIMELINE_SERVICE_WRITER_CLASS setting in
tests. Do you think it will be helpful to provide a utility method to help
people do this? Or, we may come up a minimum set of configs for ATS v2 tests
and build an utility method for that?
{quote}
It's a good suggestion. I'd probably defer that work, however. The necessary
config parameters that need to be set are slightly different for different
tests. I think we can address it in a future JIRA.
> Make HBaseTimeline[Reader|Writer]Impl default and move FileSystemTimeline*Impl
> ------------------------------------------------------------------------------
>
> Key: YARN-5189
> URL: https://issues.apache.org/jira/browse/YARN-5189
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-5189-YARN-2928.01.patch,
> YARN-5189-YARN-2928.02.patch, YARN-5189-YARN-2928.03.patch,
> YARN-5189-YARN-2928.04.patch, YARN-5189-YARN-2928.05.patch
>
>
> [[email protected]] questioned whether it made sense to default to
> an implementation that doesn't support all functionality.
> [~sjlee0] opened YARN-5174 to track updating the documentation for ATS to
> reflect the default shifting to the fully functional HBase implementation.
> It makes sense to remove a partial implementation, but on the other hand it
> is still handing in testing. Hence this jira to move the file based
> implementations to the test package and to make the HBase impls the default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
