[
https://issues.apache.org/jira/browse/YARN-5124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323571#comment-15323571
]
Carlo Curino commented on YARN-5124:
------------------------------------
Looking good... Pushing the maps-of-maps in a separate class leaves this
business logic cleaner, and we can work on improving that subclass further
later on.
In {{AMRMClientImpl}} at 323 and 675 I would just move from {{Object}} to
{{ResourceRequestInfo<T>}} in the for loops if possible.
The rest LGTM, especially given the conversation with [~subru] and [~vinodkv],
on evolving AMRMClient (YARN-5225) to a V2 that will heavily simplify things.
> Modify AMRMClient to set the ExecutionType in the ResourceRequest
> -----------------------------------------------------------------
>
> Key: YARN-5124
> URL: https://issues.apache.org/jira/browse/YARN-5124
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-5124.001.patch, YARN-5124.002.patch,
> YARN-5124.003.patch, YARN-5124.004.patch, YARN-5124.005.patch,
> YARN-5124.006.patch, YARN-5124.008.patch, YARN-5124.009.patch,
> YARN-5124.010.patch, YARN-5124.011.patch, YARN-5124.012.patch,
> YARN-5124.013.patch, YARN-5124.014.patch,
> YARN-5124_YARN-5180_combined.007.patch, YARN-5124_YARN-5180_combined.008.patch
>
>
> Currently the {{ContainerRequest}} allows the AM to set the {{ExecutionType}}
> in the AMRMClient, but it is not being set in the actual {{ResourceRequest}}
> that is sent to the RM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
