[
https://issues.apache.org/jira/browse/YARN-5242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342174#comment-15342174
]
Sunil G commented on YARN-5242:
-------------------------------
HI [~vvasudev]
Thanks for the patch. A quick doubt.
{{fitsIn}} is generally used as a public API in many critical places inside
scheduler. In this patch, {{IllegalArgumentException}} is thrown and it may
fail heartbeats etc. As I see, we were handling 2 return cases from *fitsIn*
(success / failure). Could we report failure instead of exception. Or do you
see this as a recurring failure which needs to handled as fail-fast?
> Update DominantResourceCalculator to consider all resource types in
> calculations
> --------------------------------------------------------------------------------
>
> Key: YARN-5242
> URL: https://issues.apache.org/jira/browse/YARN-5242
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-5242-YARN-3926.001.patch,
> YARN-5242-YARN-3926.002.patch
>
>
> The fitsIn function in the DominantResourceCalculator only looks at memory
> and cpu. It should be modified to use all available resource types.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
