[
https://issues.apache.org/jira/browse/YARN-5242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387546#comment-15387546
]
Rohith Sharma K S commented on YARN-5242:
-----------------------------------------
One optimization point
# {{fitsIn = fitsIn && (sResourceValue <= bResourceInformation.getValue());}}
this is there in for loop. Loop can be avoided if fitsIn is false.
# Not related to patch. In ResourceUtils.java , there is double
synchronization, i think this can be removed? Any particular reason for this?
{noformat}
synchronized (ResourceUtils.class) {
if (lock == null) {
synchronized (ResourceUtils.class) {
{noformat}
> Update DominantResourceCalculator to consider all resource types in
> calculations
> --------------------------------------------------------------------------------
>
> Key: YARN-5242
> URL: https://issues.apache.org/jira/browse/YARN-5242
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-5242-YARN-3926.001.patch,
> YARN-5242-YARN-3926.002.patch, YARN-5242-YARN-3926.003.patch
>
>
> The fitsIn function in the DominantResourceCalculator only looks at memory
> and cpu. It should be modified to use all available resource types.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
