[ 
https://issues.apache.org/jira/browse/YARN-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356646#comment-15356646
 ] 

Varun Saxena commented on YARN-5297:
------------------------------------

Thanks [~djp] for the patch.
The change looks fine. We however will now have 3 log statements one after 
another talking about the same thing, one of them being an audit log though.
Should we remove the corresponding log in ApplicationMasterService (on allocate 
and unregistration of AM) ? We can instead choose to suppress the exception too.
{noformat}
2016-06-30 12:18:37,207 [IPC Server handler 11 on 35017] INFO 
org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService: AM is 
not registered for known application attempt: 
appattempt_1467269207554_0001_000001 or RM had restarted after AM registered . 
AM should re-register.
2016-06-30 12:18:37,207 [IPC Server handler 11 on 35017] WARN 
org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger: USER=root    
IP=192.168.90.188       OPERATION=App Master Heartbeats 
TARGET=ApplicationMasterService RESULT=FAILURE  DESCRIPTION=AM is not 
registered for known application attempt: appattempt_1467269207554_0001_000001 
or RM had restarted after AM registered . AM should re-register.   PERMISSIONS= 
   APPID=application_1467269207554_0001    
APPATTEMPTID=appattempt_1467269207554_0001_000001
2016-06-30 12:18:37,209 [IPC Server handler 11 on 35017] INFO 
org.apache.hadoop.ipc.Server: IPC Server handler 11 on 35017, call 
org.apache.hadoop.yarn.api.ApplicationMasterProtocolPB.allocate from 
192.168.90.188:53563 Call#34 Retry#0: 
org.apache.hadoop.yarn.exceptions.ApplicationMasterNotRegisteredException: AM 
is not registered for known application attempt: 
appattempt_1467269207554_0001_000001 or RM had restarted after AM registered . 
AM should re-register.
{noformat}

> Avoid printing a stack trace when recovering an app after the RM restarts
> -------------------------------------------------------------------------
>
>                 Key: YARN-5297
>                 URL: https://issues.apache.org/jira/browse/YARN-5297
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Siddharth Seth
>            Assignee: Junping Du
>         Attachments: YARN-5297.patch
>
>
> The exception trace is unnecessary, and can cause confusion.
> {code}
> 2016-06-16 22:02:54,262 INFO  ipc.Server (Server.java:logException(2401)) - 
> IPC Server handler 0 on 8030, call 
> org.apache.hadoop.yarn.api.ApplicationMasterProtocolPB.allocate from 
> 172.22.79.149:42698 Call#2241 Retry#0
> org.apache.hadoop.yarn.exceptions.ApplicationMasterNotRegisteredException: AM 
> is not registered for known application attempt: 
> appattempt_1466112179488_0001_000001 or RM had restarted after AM registered 
> . AM should re-register.
>   at 
> org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.allocate(ApplicationMasterService.java:454)
>   at 
> org.apache.hadoop.yarn.api.impl.pb.service.ApplicationMasterProtocolPBServiceImpl.allocate(ApplicationMasterProtocolPBServiceImpl.java:60)
>   at 
> org.apache.hadoop.yarn.proto.ApplicationMasterProtocol$ApplicationMasterProtocolService$2.callBlockingMethod(ApplicationMasterProtocol.java:99)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:640)
>   at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:969)
>   at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2313)
>   at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2309)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1724)
>   at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2307)
> {code}
> cc [~djp]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to