[
https://issues.apache.org/jira/browse/YARN-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368105#comment-15368105
]
Junping Du commented on YARN-5297:
----------------------------------
bq. should we be removing the audit log ? Typically in production, audit logs
will go into a separate log file. And some people may use it as an input in
some of their tools as well. We in our company do not use it but are we sure
this audit log wont be useful to any of the users?
I think we should remove RM audit log here to be consistent with other
exception handling cases nearby. I didn't see how useful for audit log here in
logging a commonly happen event.
bq. Moreover, ApplicationMasterNotRegisteredException is thrown from
ApplicationMasterService#finishApplicationMaster as well.
finishApplicationMaster is a different case and the log message level is error
instead of info. There are very rarely case when AM just about to finish while
RM get restarted, so logs (include audit log) is not very annoying but could be
helpful to remind something wrong here.
> Avoid printing a stack trace when recovering an app after the RM restarts
> -------------------------------------------------------------------------
>
> Key: YARN-5297
> URL: https://issues.apache.org/jira/browse/YARN-5297
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Siddharth Seth
> Assignee: Junping Du
> Attachments: YARN-5297-v2.patch, YARN-5297.patch
>
>
> The exception trace is unnecessary, and can cause confusion.
> {code}
> 2016-06-16 22:02:54,262 INFO ipc.Server (Server.java:logException(2401)) -
> IPC Server handler 0 on 8030, call
> org.apache.hadoop.yarn.api.ApplicationMasterProtocolPB.allocate from
> 172.22.79.149:42698 Call#2241 Retry#0
> org.apache.hadoop.yarn.exceptions.ApplicationMasterNotRegisteredException: AM
> is not registered for known application attempt:
> appattempt_1466112179488_0001_000001 or RM had restarted after AM registered
> . AM should re-register.
> at
> org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.allocate(ApplicationMasterService.java:454)
> at
> org.apache.hadoop.yarn.api.impl.pb.service.ApplicationMasterProtocolPBServiceImpl.allocate(ApplicationMasterProtocolPBServiceImpl.java:60)
> at
> org.apache.hadoop.yarn.proto.ApplicationMasterProtocol$ApplicationMasterProtocolService$2.callBlockingMethod(ApplicationMasterProtocol.java:99)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:640)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:969)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2313)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2309)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1724)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2307)
> {code}
> cc [~djp]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
