[
https://issues.apache.org/jira/browse/YARN-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355323#comment-15355323
]
Steve Loughran edited comment on YARN-679 at 7/1/16 9:44 AM:
-------------------------------------------------------------
bq. I don't know why the patch is failing; I just did a test apply to trunk and
it all worked. recreating and Resubmitting with a new version number
..
bq. <cut>
Two things:
1. Once a JIRA references a github pull request, Yetus prioritizes that over
any attached files. There probably should be a change to compare date/time
stamps but that's a tremendous amount of work and we just haven't gotten to it
yet.
2. Yetus has more and more trouble applying a PR the more and more individual
commits there are. This has a lot to do with how the github API presents diff
files vs. patch files and git's own ability to apply said files.
Two options (either one will work):
1. Squash the commits into a single commit and use the GH PR
2. Remove the references to the GH PR or at least change the URL enough that
Yetus doesn't pick it up. It will then use the attached files.
was (Author: aw):
bq. I don't know why the patch is failing; I just did a test apply to trunk and
it all worked. recreating and Resubmitting with a new version number
..
bq. GITHUB PR https://github.com/apache/hadoop/pull/68
Two things:
1. Once a JIRA references a github pull request, Yetus prioritizes that over
any attached files. There probably should be a change to compare date/time
stamps but that's a tremendous amount of work and we just haven't gotten to it
yet.
2. Yetus has more and more trouble applying a PR the more and more individual
commits there are. This has a lot to do with how the github API presents diff
files vs. patch files and git's own ability to apply said files.
Two options (either one will work):
1. Squash the commits into a single commit and use the GH PR
2. Remove the references to the GH PR or at least change the URL enough that
Yetus doesn't pick it up. It will then use the attached files.
> add an entry point that can start any Yarn service
> --------------------------------------------------
>
> Key: YARN-679
> URL: https://issues.apache.org/jira/browse/YARN-679
> Project: Hadoop YARN
> Issue Type: New Feature
> Components: api
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: YARN-679-001.patch, YARN-679-002.patch,
> YARN-679-002.patch, YARN-679-003.patch, YARN-679-004.patch,
> YARN-679-005.patch, YARN-679-006.patch, YARN-679-007.patch,
> YARN-679-008.patch, org.apache.hadoop.servic...mon 3.0.0-SNAPSHOT API).pdf
>
> Time Spent: 72h
> Remaining Estimate: 0h
>
> There's no need to write separate .main classes for every Yarn service, given
> that the startup mechanism should be identical: create, init, start, wait for
> stopped -with an interrupt handler to trigger a clean shutdown on a control-c
> interrupt.
> Provide one that takes any classname, and a list of config files/options
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
