[ 
https://issues.apache.org/jira/browse/YARN-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090020#comment-15090020
 ] 

Steve Loughran edited comment on YARN-679 at 7/1/16 9:45 AM:
-------------------------------------------------------------

GitHub user steveloughran opened a pull request:
    <cut>



was (Author: githubbot):
GitHub user steveloughran opened a pull request:

    https://github.com/apache/hadoop/pull/68

    YARN-679 service launcher

    Pull-request version of YARN-679; initially the 005 patch plus corrections 
of javadocs and checkstyles

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/steveloughran/hadoop stevel/YARN-679-launcher

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hadoop/pull/68.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #68
    
----
commit 8190fcbea75d203a43052339736ea2a412d44f16
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-03T17:09:26Z

    YARN-679: launcher code move

commit 5216a290371eb9050bf1fc98cd82aeea05f2f9d5
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-03T18:43:41Z

    YARN-679 service launcher adapting to changes in ExitUtil; passng params 
down as a list


commit a8ea0b26cb101dbfc47bb8349bfa3510d0701efe
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-04T09:46:45Z

    YARN-679 add javadocs & better launching for service-launcher

commit dcb4599ca9ed1feadff2d0149819640740405201
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-04T10:54:44Z

    YARN-679 move IRQ escalation into its own class for cleanliness and 
testability; lots of javadocs

commit bdd41f632deeb60a0b309e891755630d93956280
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-04T13:19:53Z

    YARN-679 initial TestInterruptHandling test

commit ff422b3dd70a9a39d7668b063811acee285fcbba
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-04T14:26:33Z

    YARN-679 TestInterruptHandling

commit 1d35197f8a8d80d3ca9aa4691b7f086686fcb454
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-04T14:40:13Z

    YARN-679 TestInterruptHandling final test -that blocking service stops 
don't stop shutdown from kicking in


commit ddbdfae3f7e2ce79f3c0138bc5c855bde8094c2f
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-04T15:41:19Z

    YARN-679: service exception handling improvements during creation, 
sprintf-formatted exception creation

commit db0a2ef4e8a46bfab6db4ec7a89cde70779432c8
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-04T15:56:11Z

    YARN-679 service instantiation failures

commit 2a95da1a320811c381b93c14125d56e2d21798c1
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-04T17:41:54Z

    YARN-679 lots more on exception handling and error code propagation, 
including making ServiceStateException have an exit code and propagate any 
inner one

commit 6fc00fa46e47d1ae6039d2e6d16b8bfb61c87ea1
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-04T19:12:13Z

    YARN-679 move test services into their own package; test for stop in 
runnable

commit 4dfed85a0a86440784583c41d2249d6c1106889d
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-04T20:00:20Z

    YARN-679 conf arg passdown validated

commit 6c12bb43a1d4554e7e196db7f9994562bd899fee
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T10:03:34Z

    YARN-679 test for service launch

commit 803250fb6810e7bd2373c53c9c07d9548c9eb71d
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T12:46:26Z

    YARN-679 test for bindArgs operations

commit f21f0fe6bdd8b1815080bdead225572c93430a24
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T13:05:30Z

    YARN-679 add AbstractLaunchedService base class for launched services, 
tests to verify that a subclass of this rejects arguments -but doesn't reject 
--conf args as they are stripped

commit a7056381a61fac239f71c7ecb8c40b74c4330864
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T13:24:24Z

    YARN-679 exception throwing/catching in execute

commit 24b74787dc52ca41dd6fde9db6c1dddb471ba1b8
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T14:13:35Z

    YARN-679 verify that constructor inits are handled

commit 554e317a0f2ef6ea353887e0cc501e0d27eb9a27
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T14:28:14Z

    services that only have a (String) constructor are handled by giving them 
their classname as a name

commit 49e457785752c1c27137ce1bb448b00f565cff20
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T14:31:43Z

    YARN-679 optimise imports

commit 62984ff26819965e86eb8727d1c5d8b73cd7fce9
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T16:45:29Z

    YARN-679 inner Launching logic with assertions and checks that Throwables 
get picked up and wrapped

commit ad8b79023536ebb1975613abbeb592f8826c06b2
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T18:48:21Z

    YARN-679 executed services close unless execute=false on launch, at which 
point they don't even get executed

commit f73e856e8c2cf4d5c3fa2c9b383e110917f79700
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T18:49:00Z

    YARN-679 rm unused override

commit 97a2af7be6a93af480a142eba93a130d98e2bd24
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T19:09:49Z

    YARN-679 give all tests a TestService to identify their role and aid bulk 
mvn test runs

commit 7276e349a51fb7593fa4edcd8a917bf52eea36a7
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T19:28:47Z

    YARN-679 rename LaunchedService interface LaunchableService

commit c0f5fa3d24f7ce840b1457f0d0c1a3e8ac94bf9a
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T20:39:18Z

    YARN-679 test (and fix) that if a launched service -> stopped in startup, 
then it isn't execute()'d.

commit a3fac73ffbd9a99ee4ace03fd96fa9d1864c8b75
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-05T22:44:30Z

    YARN-679 interrupt escalation rework (weak refs), tests of shutdown hook 
actions; lots of docs

commit c69f202837f443aeeeb87e7f9b4dcc48bec57694
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-06T07:50:38Z

    YARN-679 test that a non-conf XML file triggers a meaningful failure 
message in CLI parse, not some XML parser stack elsewhere

commit bb440002b4cdb089bf8f4401394a8b65ef7e1e98
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-06T09:14:39Z

    YARN-679 make code to generate a startup/shutdown string public

commit 1a53d3ae835cd37be5f907fa1200e86a37d97729
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-06T09:15:08Z

    YARN-679 javadocs -including package

commit 5a07f4a18fdfa357bb8aeb3ebb8d92ba78ff4099
Author: Steve Loughran <ste...@apache.org>
Date:   2014-06-06T15:44:46Z

    YARN-679 javadocs -including package

----


> add an entry point that can start any Yarn service
> --------------------------------------------------
>
>                 Key: YARN-679
>                 URL: https://issues.apache.org/jira/browse/YARN-679
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: api
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: YARN-679-001.patch, YARN-679-002.patch, 
> YARN-679-002.patch, YARN-679-003.patch, YARN-679-004.patch, 
> YARN-679-005.patch, YARN-679-006.patch, YARN-679-007.patch, 
> YARN-679-008.patch, org.apache.hadoop.servic...mon 3.0.0-SNAPSHOT API).pdf
>
>          Time Spent: 72h
>  Remaining Estimate: 0h
>
> There's no need to write separate .main classes for every Yarn service, given 
> that the startup mechanism should be identical: create, init, start, wait for 
> stopped -with an interrupt handler to trigger a clean shutdown on a control-c 
> interrupt.
> Provide one that takes any classname, and a list of config files/options



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to