[
https://issues.apache.org/jira/browse/YARN-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383451#comment-15383451
]
Chris Douglas commented on YARN-5121:
-------------------------------------
+1 overall, though I haven't tested it on multiple platforms. Thanks for also
updating the L&N
Minor:
* Leftover debug stmt in {{configuration.c}}?
{noformat}
+ fprintf(stderr, "fn=%s\n",file_name);
strncpy(strrchr(buffer, '/') + 1, file_name, EXECUTOR_PATH_MAX);
real_fname = buffer;
+ fprintf(stderr, "real_fname=%s\n",real_fname);
{noformat}
* In {{container-executor.c}}, should "Error signalling process group %d with
signal %d - %s\n" go to LOGFILE instead of stderr?
* -0 on the whitespace fixes... I'd prefer to keep the history, but the patch
touches enough code that it may be worthwhile.
> fix some container-executor portability issues
> ----------------------------------------------
>
> Key: YARN-5121
> URL: https://issues.apache.org/jira/browse/YARN-5121
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 3.0.0-alpha1
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Attachments: YARN-5121.00.patch, YARN-5121.01.patch,
> YARN-5121.02.patch, YARN-5121.03.patch
>
>
> container-executor has some issues that are preventing it from even compiling
> on the OS X jenkins instance. Let's fix those. While we're there, let's
> also try to take care of some of the other portability problems that have
> crept in over the years, since it used to work great on Solaris but now
> doesn't.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
