[
https://issues.apache.org/jira/browse/YARN-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400276#comment-15400276
]
Chris Douglas commented on YARN-5121:
-------------------------------------
+1 from me. Thanks, Allen for the patch and ChrisN for review.
bq. I did remove some other debugging code, but that one I thought was useful
due to aggressive use of ternary operators
I haven't looked at the context, but if {{ret}} can never be null in that case
({{real_fname}} is never null?), then the tenary operator is redundant. If it
can be null, then the new debug stmt can cause a segfault before it prints?
Nit-picking in any case.
> fix some container-executor portability issues
> ----------------------------------------------
>
> Key: YARN-5121
> URL: https://issues.apache.org/jira/browse/YARN-5121
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 3.0.0-alpha1
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Attachments: YARN-5121.00.patch, YARN-5121.01.patch,
> YARN-5121.02.patch, YARN-5121.03.patch, YARN-5121.04.patch,
> YARN-5121.06.patch, YARN-5121.07.patch
>
>
> container-executor has some issues that are preventing it from even compiling
> on the OS X jenkins instance. Let's fix those. While we're there, let's
> also try to take care of some of the other portability problems that have
> crept in over the years, since it used to work great on Solaris but now
> doesn't.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
