[
https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387522#comment-15387522
]
Sunil G commented on YARN-5382:
-------------------------------
Hi [~vrushalic]
Thanks for sharing the patch. Few comments
1. {{RMAppKillEvent}} is now used as a special child event when client invokes
kill command on an app for extra audit logging. For other app kill scenarios
within scheduler, we still use {{RMAppEvent}} only. So could we add more
clarity to the event *name* to indicate it does only an extra logging. Else we
can use this new {{RMAppKillEvent}} for all internal callers and pass EMPTY
message.
2. {{RMAppKillEvent}} may not need to take {{RMAppEventType.KILL}} as an
argument. Since its a kill event, we can consider {{RMAppEventType.KILL}} as
event while invoking {{super}} from {{RMAppKillEvent}} constructor.
> RM does not audit log kill request for active applications
> ----------------------------------------------------------
>
> Key: YARN-5382
> URL: https://issues.apache.org/jira/browse/YARN-5382
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.7.2
> Reporter: Jason Lowe
> Assignee: Vrushali C
> Attachments: YARN-5382-branch-2.7.01.patch,
> YARN-5382-branch-2.7.02.patch, YARN-5382-branch-2.7.03.patch
>
>
> ClientRMService will audit a kill request but only if it either fails to
> issue the kill or if the kill is sent to an already finished application. It
> does not create a log entry when the application is active which is arguably
> the most important case to audit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
