[
https://issues.apache.org/jira/browse/YARN-4888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402970#comment-15402970
]
Wangda Tan commented on YARN-4888:
----------------------------------
Thanks [~subru],
Some comments:
1) SchedulerRequestKey.UNDEFINED is not used by anybody, can be removed?
2) Changes of FiCaSchedulerApp can be removed, because in
RegularContainerAllocator, schedulerKey is already updated
3) SchedulerRequestKey.compareTo:
bq. return (int) (allocationRequestId - o.getAllocationRequestId());
could lead to a number becomes negative if result > Integer.max_value,
instead you should use Long.compare(...)
4) It looks like there're some duplicated code for tests, could we add a new
parameterized test (such as TestSchedulingWithAllocationId) and test both
scheduler?
> Changes in RM container allocation for identifying resource-requests
> explicitly
> -------------------------------------------------------------------------------
>
> Key: YARN-4888
> URL: https://issues.apache.org/jira/browse/YARN-4888
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Subru Krishnan
> Assignee: Subru Krishnan
> Attachments: YARN-4888-WIP.patch, YARN-4888-v0.patch,
> YARN-4888-v2.patch, YARN-4888-v3.patch, YARN-4888-v4.patch,
> YARN-4888-v5.patch, YARN-4888.001.patch
>
>
> YARN-4879 puts forward the notion of identifying allocate requests
> explicitly. This JIRA is to track the changes in RM app scheduling data
> structures to accomplish it. Please refer to the design doc in the parent
> JIRA for details.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
