[
https://issues.apache.org/jira/browse/YARN-5467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421978#comment-15421978
]
Subru Krishnan commented on YARN-5467:
--------------------------------------
Thanks [~giovanni.fumarola] for working on this. Good job especially with the
test coverage.
I have a few minor comments:
* Move the _InputValidator_ classes to
*org.apache.hadoop.yarn.server.federation.store.utils* package.
* Align the _InputValidator_ class names with the Store interface names.
* Consider logging the exception before throwing. This way we need to only
log in single place for any input validation errors instead of in each store
impl.
* In {{FederationApplicationInputValidator::checkApplicationId}}, we should
also check if the value if parseable into an _ApplicationId_.
* There are few typos in the exception message, for e.g:
*checkSubClusterPolicyConfiguration*, *checkQueue*, etc.
* Remove the *Correct* suffix from tests as they check both valid & invalid
scenarios.
* Nit: move the null tests before the invalid tests.
* Can you integrate the _InputValidators_with {{MemoryFederationStateStore}}
as now they are not being used anywhere.
> InputValidator for the FederationStateStore internal APIs
> ---------------------------------------------------------
>
> Key: YARN-5467
> URL: https://issues.apache.org/jira/browse/YARN-5467
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Subru Krishnan
> Assignee: Giovanni Matteo Fumarola
> Attachments: YARN-5467-YARN-2915.v0.patch,
> YARN-5467-YARN-2915.v1.patch, YARN-5467-YARN-2915.v2.patch
>
>
> We need to check for mandatory fields, well formed-ness (for address fields)
> etc of input params to FederationStateStore. This is common across all Store
> implementations and can be used as a _fail-fast_ mechanism on the client side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
