[
https://issues.apache.org/jira/browse/YARN-5467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423736#comment-15423736
]
Subru Krishnan commented on YARN-5467:
--------------------------------------
[~giovanni.fumarola], the latest patch LGTM. I just have one request, can you
use slf4j instead of log4j for the Logger especially since these are new
classes. Thanks.
> InputValidator for the FederationStateStore internal APIs
> ---------------------------------------------------------
>
> Key: YARN-5467
> URL: https://issues.apache.org/jira/browse/YARN-5467
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Subru Krishnan
> Assignee: Giovanni Matteo Fumarola
> Attachments: YARN-5467-YARN-2915.v0.patch,
> YARN-5467-YARN-2915.v1.patch, YARN-5467-YARN-2915.v2.patch,
> YARN-5467-YARN-2915.v3.patch, YARN-5467-YARN-2915.v4.patch,
> YARN-5467-YARN-2915.v5.patch, YARN-5467-YARN-2915.v6.patch
>
>
> We need to check for mandatory fields, well formed-ness (for address fields)
> etc of input params to FederationStateStore. This is common across all Store
> implementations and can be used as a _fail-fast_ mechanism on the client side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
