[ https://issues.apache.org/jira/browse/YARN-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun Suresh updated YARN-4889: ------------------------------ Attachment: YARN-4889.003.patch Thanks for the review [~kasha].. Updating patch addressing some of your comments bq. A bunch of comments seem to take the form "WITH(OUT) the allocationRequestId specified". Can we reword them to "with/without the/a specified allocationRequestId"? My intent was to convey to the user that the new *getMatchingRequests()* methods (with only a single "allocationRequestId" argument) can be used to match ONLY those ContainerRequests that were made with the *allocationRequestId* set. I have re-worded it a bit in the latest patch.. please take a look bq. Just thinking out aloud: ResourceRequest and ContainerRequest could benefit from a builder instead of the newInstance way. Totally agree. I've raised YARN-5552 to track this > Changes in AMRMClient for identifying resource-requests explicitly > ------------------------------------------------------------------ > > Key: YARN-4889 > URL: https://issues.apache.org/jira/browse/YARN-4889 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Subru Krishnan > Assignee: Arun Suresh > Attachments: YARN-4889.001.patch, YARN-4889.002.patch, > YARN-4889.003.patch > > > YARN-4879 proposes the notion of identifying allocate requests explicitly.. > This JIRA is to track the changes in AMRMClient to keep it wire compatible > with the changes. Please refer to the design doc in the parent JIRA for > details. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org