[
https://issues.apache.org/jira/browse/YARN-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arun Suresh updated YARN-4889:
------------------------------
Attachment: YARN-4889.004.patch
Thanks for the review [~leftnoteasy]
Updating patch addressing your comments.
bq. Why previous return values of getMatchingRequests is List<Collection> but
the newly added getMatchingRequests is Collection? Why previous return value is
List of Collection?
The reason why the return type of the existing method is a List<Collection> is
because it is a 'fuzzy' match. For eg. It is possible that the input to the old
functions asked for ContainerRequests that match a Capability *c* and it will
match multiple {{ResourceRequestInfo}} objects with capability *c'* where
*fitIn(c', c)* is true and for each of them you have a separate collection. The
*allocationRequestId* match is actually more of an exact match and does not
require an outer collection.
> Changes in AMRMClient for identifying resource-requests explicitly
> ------------------------------------------------------------------
>
> Key: YARN-4889
> URL: https://issues.apache.org/jira/browse/YARN-4889
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Subru Krishnan
> Assignee: Arun Suresh
> Attachments: YARN-4889.001.patch, YARN-4889.002.patch,
> YARN-4889.003.patch, YARN-4889.004.patch
>
>
> YARN-4879 proposes the notion of identifying allocate requests explicitly..
> This JIRA is to track the changes in AMRMClient to keep it wire compatible
> with the changes. Please refer to the design doc in the parent JIRA for
> details.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
