[ 
https://issues.apache.org/jira/browse/YARN-5375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434153#comment-15434153
 ] 

Rohith Sharma K S commented on YARN-5375:
-----------------------------------------

I am fine going with subclass of memoryRMStateStore and it can be used 
everywhere.
One comment from earlier patch in MockRM is need to take care whenever drain 
for Stastore dispatcher, again need to wait for draining rm-dispatcher. This is 
required because state store trigger another event to rm-dispatcher.

And another approach I was thinking to override the dispatcher in RMStateStore 
while creating itself. But issue with that state-store is created using 
reflection where I could not override methods in RMstatestore.  

> invoke MockRM#drainEvents implicitly in MockRM methods to reduce test failures
> ------------------------------------------------------------------------------
>
>                 Key: YARN-5375
>                 URL: https://issues.apache.org/jira/browse/YARN-5375
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: sandflee
>            Assignee: sandflee
>         Attachments: YARN-5375.01.patch, YARN-5375.03.patch, 
> YARN-5375.04.patch, YARN-5375.05.patch, YARN-5375.06.patch
>
>
> seen many test failures related to RMApp/RMAppattempt comes to some state but 
> some event are not processed in rm event queue or scheduler event queue, 
> cause test failure, seems we could implicitly invokes drainEvents(should also 
> drain sheduler event) in some mockRM method like waitForState



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to