[ 
https://issues.apache.org/jira/browse/YARN-5375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434730#comment-15434730
 ] 

sandflee commented on YARN-5375:
--------------------------------

bq. One comment from earlier patch in MockRM is need to take care whenever 
drain for Stastore dispatcher, again need to wait for draining rm-dispatcher. 
This is required because state store trigger another event to rm-dispatcher.
yes, we should take care of this. but double drain drain rm-dispatcher may not 
help, because rm state store may have new Event again. One approach is to add a 
timestamp to drainDispatcher to record newEvent add time, after drain 
StateStore event, we could check the timestamp of rm-disptacher, if not 
updated, we could make sure that all events are drained.  

> invoke MockRM#drainEvents implicitly in MockRM methods to reduce test failures
> ------------------------------------------------------------------------------
>
>                 Key: YARN-5375
>                 URL: https://issues.apache.org/jira/browse/YARN-5375
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: sandflee
>            Assignee: sandflee
>         Attachments: YARN-5375.01.patch, YARN-5375.03.patch, 
> YARN-5375.04.patch, YARN-5375.05.patch, YARN-5375.06.patch
>
>
> seen many test failures related to RMApp/RMAppattempt comes to some state but 
> some event are not processed in rm event queue or scheduler event queue, 
> cause test failure, seems we could implicitly invokes drainEvents(should also 
> drain sheduler event) in some mockRM method like waitForState



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to