[
https://issues.apache.org/jira/browse/YARN-5323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453381#comment-15453381
]
Subru Krishnan commented on YARN-5323:
--------------------------------------
Thanks [~curino] for working on this. The latest patch mostly LGTM, have a few
minor comments:
* I feel it would be better to have {{FederationStateStoreFacade}} in
{{FederationPolicyInitializationContext}} and use that instead of passing
active sub-cluster map in every invocation, that too of both
_Router/AMRMProxyFederationPolicy_.
* There are few public methods missing Javadocs like getters/setters in
{{FederationPolicyInitializationContext}}.
* IMO few of the open Yetus checkstyle/javadoc warnings are fixable.
> Policies APIs (for Router and AMRMProxy policies)
> -------------------------------------------------
>
> Key: YARN-5323
> URL: https://issues.apache.org/jira/browse/YARN-5323
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Affects Versions: YARN-2915
> Reporter: Carlo Curino
> Assignee: Carlo Curino
> Attachments: YARN-5323-YARN-2915.05.patch,
> YARN-5323-YARN-2915.06.patch, YARN-5323.01.patch, YARN-5323.02.patch,
> YARN-5323.03.patch, YARN-5323.04.patch
>
>
> This JIRA tracks APIs for the policies that will guide the Router and
> AMRMProxy decisions on where to fwd the jobs submission/query requests as
> well as ResourceRequests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
