[
https://issues.apache.org/jira/browse/YARN-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459847#comment-15459847
]
Subru Krishnan commented on YARN-5486:
--------------------------------------
Thanks [~asuresh] for the patch. I looked at it and have a few questions:
* Why do we need _LinkedHashMap_ in {{OpportunisticContainerContext}}?
* Why are reverting OPPORTUNISTIC_CONTAINER_ALLOCATION_ENABLED to
DIST_SCHEDULING_ENABLED?
* {{TestOpportunisticsContainerAllocation}} seems to have redundant harness
code from {{TestAMRMClient}}?
* I don't see assertions on _containerType_ in the allocation part of
{{TestOpportunisticsContainerAllocation}}?
* Can we also fix the sleep logic in
{{TestOpportunisticsContainerAllocation}} (Refer to discussion on
YARN-5389/YARN-5393)?
> Update OpportunisticContainerAllocatorAMService::allocate method to handle
> OPPORTUNISTIC container requests
> -----------------------------------------------------------------------------------------------------------
>
> Key: YARN-5486
> URL: https://issues.apache.org/jira/browse/YARN-5486
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Arun Suresh
> Assignee: Konstantinos Karanasos
> Attachments: YARN-5486.001.patch
>
>
> YARN-5457 refactors the Distributed Scheduling framework to move the
> container allocator to yarn-server-common.
> This JIRA proposes to update the allocate method in the new AM service to use
> the OpportunisticContainerAllocator to allocate opportunistic containers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
