[
https://issues.apache.org/jira/browse/YARN-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528034#comment-15528034
]
Arun Suresh commented on YARN-5486:
-----------------------------------
Thanks for updating the patch [~kkaranasos]
One possible optimization:
* Currently, the allocator is called in the same thread as the allocate call.
Instead of holding up the AM, this can be done asynchronously and the new
containers can be pushed to the
SchedulerApplicationAttempt::newlyAllocatedContainers as and when the
allocation completes.. but i'm fine handling this in a separate JIRA.
Couple of minor nits:
* The {{TestOpportunisticContainerAllocation}} has a lot of code in common with
{{TestAMRMClient}}. I understand it is difficult to extend the later since most
of the fields are statically initialized and pulling it out might not be
trivial. Can you maybe raise a JIRA to track this?
* The comment above the {{DistributedScheduler::updateAllocateResponse()}} has
an extra *if* which can be removed
* In {{ResourceManager}}, line 1186, the exception message should read *be
enabled when distr...*
+1 pending the above and a clean Jenkins run.
> Update OpportunisticContainerAllocatorAMService::allocate method to handle
> OPPORTUNISTIC container requests
> -----------------------------------------------------------------------------------------------------------
>
> Key: YARN-5486
> URL: https://issues.apache.org/jira/browse/YARN-5486
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Arun Suresh
> Assignee: Konstantinos Karanasos
> Attachments: YARN-5486.001.patch, YARN-5486.002.patch,
> YARN-5486.003.patch
>
>
> YARN-5457 refactors the Distributed Scheduling framework to move the
> container allocator to yarn-server-common.
> This JIRA proposes to update the allocate method in the new AM service to use
> the OpportunisticContainerAllocator to allocate opportunistic containers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
