[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jian He updated YARN-5621:
--------------------------
Attachment: YARN-5621.4.patch
Thanks for the comments,
bq. I'm asking why this is an absolute path
ah, IIRC, this is because the ContainerExecutor#symLink interface is also
shared by DefaultContainerExecutor which requires an absolute path, so I simply
pass the absolute path down. For the LinuxContainerExecutor, you are right, we
may not need the absolute path.
bq. Is it possible for a user to try to get a symlink for:
IIUC, I think whatever can happen to the run-script could happen to the
launch_script in the first place.
bq. This JIRA follows a similar pattern, but without validation of args in the
CE. If it were restricted s.t. the source had a fixed format in nmPrivate and
the destination was derived from a formatted ContainerID, it could have
comparable guarantees as the container start.
You both raised a good point, I should add validations. Also I probably should
rename the run-script to something else.
bq. It could receive a symlink command on a heartbeat, it's already running as
the user,
This may be a viable approach, we need to change the localizer heartbeat to
send the symlink path. But if we want to create all symlinks in one go, this
approach will not work.
I updated the patch to include some input validations as suggested by Chris.
> Support LinuxContainerExecutor to create symlinks for continuously localized
> resources
> --------------------------------------------------------------------------------------
>
> Key: YARN-5621
> URL: https://issues.apache.org/jira/browse/YARN-5621
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Jian He
> Attachments: YARN-5621.1.patch, YARN-5621.2.patch, YARN-5621.3.patch,
> YARN-5621.4.patch
>
>
> When new resources are localized, new symlink needs to be created for the
> localized resource. This is the change for the LinuxContainerExecutor to
> create the symlinks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
