[ 
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486721#comment-15486721
 ] 

Jian He commented on YARN-5620:
-------------------------------


[~asuresh], found a couple more issues while looking at the other patch:
- not sure if I missed something, Looks like the 
ReInitializationContext#resourceSet is never initialized with the pending 
resources ?
- Also, the symlinks for the upgraded resources are not overridden correctly.
we probably need to change this to be a map of (symlink -> localizedPath) so 
that the same symlink can be overwritten to point to the new resource.  If this 
involves a chain of caller changes, it can be done separately. 
{code}
  private Map<Path, List<String>> localizedResources =
      new ConcurrentHashMap<>();
{code}

> Core changes in NodeManager to support re-initialization of Containers with 
> new launchContext
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-5620
>                 URL: https://issues.apache.org/jira/browse/YARN-5620
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5620.001.patch, YARN-5620.002.patch, 
> YARN-5620.003.patch, YARN-5620.004.patch, YARN-5620.005.patch, 
> YARN-5620.006.patch, YARN-5620.007.patch, YARN-5620.008.patch, 
> YARN-5620.009.patch, YARN-5620.010.patch, YARN-5620.011.patch, 
> YARN-5620.012.patch
>
>
> JIRA proposes to modify the ContainerManager (and other core classes) to 
> support upgrade of a running container with a new {{ContainerLaunchContext}} 
> as well as the ability to rollback the upgrade if the container is not able 
> to restart using the new launch Context. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to