Sunil G updated YARN-4945:
    Attachment: YARN-2009.v3.patch

Thanks [~leftnoteasy] and [~eepayne]

LeafQueue#getAllApplications impl had that bug pointed by Eric. Fixed the same. 
Nice catch.

should we only have a "queue.intra-queue-preemption-enabled"?
Could we have something like {{select_based_on_intra_queue_policies}} ?

bq.partitionToUnderServedQueues can be kept in 
Actually i update list to this map from Inter queue policy, and use it in intra 
queue. So we are having 2 objects from 2 types of calculator. So sharing from 
PCPP makes more sense rt?

bq.Map<String, LinkedHashSet<String>> could be Map<String, List<String>>. 
(LinkedHashSet is not necessarily needed, because we won't have two 
TempQueuePerPartition with the same queueName and same partition)
Here I think we needed LinkedHashSet. Reason is that 
{{computeFixpointAllocation}} from AbsPreemptCalc class, same queue can be 
added back to {{orderedByNeed}} priority queue. 

bq.better to move to Intellij? 
Yup. definitely in my todo’s :)

bq.Move getTotalPendingRequestsPerPartition to ResourceUsage?
Its really helpful to have. But interestingly we need to add to 
resourceUsage#pending from {{AppSchedulingInfo}} rather than 
{{FiCaSchedulerApp}}. Also we have {{attemptResourceUsage}} present in app 
level (for used and reserve), and another {{resourceUsage}} present in 
AppSchedulingInfo (for pending). I think we need some refactoring there . we 
can do that in separate ticket. thoughts?

bq.All non-abstract methods can be static, correct? All TODOs in comments are 
done, correct?
Yes. Done.

bq.how about call it something like IntraQueuePreemptionComputePlugin?
Make sense to me.

bq.Is it better to rename Temp- to something like AppPartitionSnapshot or 
Yes. will handle in separate ticket.

> [Umbrella] Capacity Scheduler Preemption Within a queue
> -------------------------------------------------------
>                 Key: YARN-4945
>                 URL: https://issues.apache.org/jira/browse/YARN-4945
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Wangda Tan
>         Attachments: Intra-Queue Preemption Use Cases.pdf, 
> IntraQueuepreemption-CapacityScheduler (Design).pdf, YARN-2009-wip.2.patch, 
> YARN-2009-wip.patch, YARN-2009-wip.v3.patch, YARN-2009.v0.patch, 
> YARN-2009.v1.patch, YARN-2009.v2.patch, YARN-2009.v3.patch
> This is umbrella ticket to track efforts of preemption within a queue to 
> support features like:
> YARN-2009. YARN-2113. YARN-4781.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to