[ 
https://issues.apache.org/jira/browse/YARN-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498281#comment-15498281
 ] 

Jian He commented on YARN-5637:
-------------------------------

lgtm, only comment is
This
{code}
      if (oldLaunchContext != null) {
        this.oldLaunchContext = oldLaunchContext;
        this.oldResourceSet = oldResourceSet;
      } else {
        this.oldLaunchContext = null;
        this.oldResourceSet = null;
      }
{code}
seems equivalent to
{code}
        this.oldLaunchContext = oldLaunchContext;
        this.oldResourceSet = oldResourceSet;
{code}

> Changes in NodeManager to support Container rollback and commit
> ---------------------------------------------------------------
>
>                 Key: YARN-5637
>                 URL: https://issues.apache.org/jira/browse/YARN-5637
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5637.001.patch, YARN-5637.002.patch, 
> YARN-5637.003.patch, YARN-5637.004.patch, YARN-5637.005.patch, 
> YARN-5637.006.patch
>
>
> YARN-5620 added support for re-initialization of Containers using a new 
> launch Context.
> This JIRA proposes to use the above feature to support upgrade and subsequent 
> rollback or commit of the upgrade.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to