[ https://issues.apache.org/jira/browse/YARN-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500546#comment-15500546 ]
Varun Vasudev commented on YARN-5637: ------------------------------------- Thanks for the patch [~asuresh]! My apologies for the delay in responding. The patch looks mostly good to me. The only question I have to around deleting resources as part of the rollback. Let's say you download a new jar as part of the upgrade. When you do a rollback, this jar will be part of the classpath and this could result in the rollback failing(due to class/function not found issues). Is my understanding wrong? I wouldn't hold up the patch for fixing this - we should probably do it in a different JIRA. > Changes in NodeManager to support Container rollback and commit > --------------------------------------------------------------- > > Key: YARN-5637 > URL: https://issues.apache.org/jira/browse/YARN-5637 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Arun Suresh > Assignee: Arun Suresh > Attachments: YARN-5637.001.patch, YARN-5637.002.patch, > YARN-5637.003.patch, YARN-5637.004.patch, YARN-5637.005.patch, > YARN-5637.006.patch, YARN-5637.007.patch > > > YARN-5620 added support for re-initialization of Containers using a new > launch Context. > This JIRA proposes to use the above feature to support upgrade and subsequent > rollback or commit of the upgrade. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org