[ 
https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15512376#comment-15512376
 ] 

Sunil G commented on YARN-5611:
-------------------------------

Thanks [~rohithsharma], few high level comments.
  1.
{code}
            long newLifetime = newAppTimeouts.getLifetime();
            if (newLifetime < 0) {
{code}
{{newLifetime}} can be 0. Is there any special meaning for timeout value of 0. 
i could not find any special handling for that.
If there are no special handling, we could validate that out to avoid some 
extra code cycles.


2.  {{rmContext.getRMAppLifetimeMonitor().updateApplicationLifetime()}} needs 
to check whether app was already registered earlier. 
3. I think we can publish this information to timeline also through appUpdated 
event .


> Provide an API to update lifetime of an application.
> ----------------------------------------------------
>
>                 Key: YARN-5611
>                 URL: https://issues.apache.org/jira/browse/YARN-5611
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-5611.patch, YARN-5611.v0.patch
>
>
> YARN-4205 monitors an Lifetime of an applications is monitored if required. 
> Add an client api to update lifetime of an application. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to