Rohith Sharma K S commented on YARN-5611:

bq. The appIdToTimeoutTypeMapping may be not needed.
I added this for couple of reasons. 
# Caching, need not to create RMAppToMonitor object on every update or on 
getRemainingTime or any other.
# Since, YARN may support more timeout for an application, it would help to 
track what all are the timeouts for an application has been registered. Say 
app1 might want only lifetime, app2 might want lifetime & queue_time. In such 
cases, it is easier to look up this mapping and get registered timeouts for an 

bq. Also, when we update the timeout, the new timeout should be current 
timestamp + newTimeout value. Later, we will also send the remaining lifetime 
to user if user queries, this way, it's easier to reason - what user sets as 
the timeout value is what user will get when he queries.
Good point. let me change it. Note: as of now, we are not storing timeout 
values in statestore apart from submissionContext. Submission context will 
contains only timeout which is not absolute. But, currently we are supporting 
only lifetime, then we can recover on RM restart. So, in future if any such use 
case for supporting different timeouts then for RM HA cases, we need to recover 
either monitoringStartTime or EndTime.

> Provide an API to update lifetime of an application.
> ----------------------------------------------------
>                 Key: YARN-5611
>                 URL: https://issues.apache.org/jira/browse/YARN-5611
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-5611.patch, 0002-YARN-5611.patch, 
> YARN-5611.v0.patch
> YARN-4205 monitors an Lifetime of an applications is monitored if required. 
> Add an client api to update lifetime of an application. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to