[ 
https://issues.apache.org/jira/browse/YARN-5638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522262#comment-15522262
 ] 

Rohith Sharma K S commented on YARN-5638:
-----------------------------------------

bq. Did not quite get the point here... I think we're checking both fields?
I mean below code is OR condition. I think it should be AND right?
{code}
public boolean isStamped() {        return (getRMIdentifier() != 
DEFAULT_TIMESTAMP_VALUE)               || (getVersion() != 
DEFAULT_TIMESTAMP_VALUE);     }
{code}

bq. On the other hand, the RM will only send related collector's information to 
each of the NMs.
In code, ResourceTrackerService#setAppCollectorsMapToResponse, every heartbeat 
response collector address has been sent to all the running application in that 
Node. {{liveAppCollectorsMap}} holds the data.


> Introduce a collector timestamp to uniquely identify collectors creation 
> order in collector discovery
> -----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5638
>                 URL: https://issues.apache.org/jira/browse/YARN-5638
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: YARN-5638-trunk.v1.patch, YARN-5638-trunk.v2.patch, 
> YARN-5638-trunk.v3.patch
>
>
> As discussed in YARN-3359, we need to further identify timeline collectors' 
> creation order to rebuild collector discovery data in the RM. This JIRA 
> proposes to use <rm_timestamp, logical_version_number> to order collectors 
> for each application in the RM. This timestamp can then be used when a 
> standby RM becomes active and rebuild collector discovery data. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to