[ 
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523515#comment-15523515
 ] 

Jian He commented on YARN-5620:
-------------------------------

[~asuresh],
I think we need one more jira to release the older than previous resources, if 
the container is upgraded from v1 -> v2 -> v3.  The v1 resources are not 
referenced by container any more, it needs to be released, I briefly checked 
the code, maybe below code in ResourceLocalizationService need to be invoked 
for v1 resources.
{code}
    for (Map.Entry<LocalResourceVisibility, Collection<LocalResourceRequest>> e 
:
         rsrcs.entrySet()) {
      LocalResourcesTracker tracker = getLocalResourcesTracker(e.getKey(), 
c.getUser(), 
          c.getContainerId().getApplicationAttemptId()
          .getApplicationId());
      for (LocalResourceRequest req : e.getValue()) {
        tracker.handle(new ResourceReleaseEvent(req,
            c.getContainerId()));
      }
    }
{code}

> Core changes in NodeManager to support re-initialization of Containers with 
> new launchContext
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-5620
>                 URL: https://issues.apache.org/jira/browse/YARN-5620
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>             Fix For: 2.9.0, 3.0.0-alpha2
>
>         Attachments: YARN-5620.001.patch, YARN-5620.002.patch, 
> YARN-5620.003.patch, YARN-5620.004.patch, YARN-5620.005.patch, 
> YARN-5620.006.patch, YARN-5620.007.patch, YARN-5620.008.patch, 
> YARN-5620.009.patch, YARN-5620.010.patch, YARN-5620.011.patch, 
> YARN-5620.012.patch, YARN-5620.013.patch, YARN-5620.014.patch, 
> YARN-5620.015.patch, YARN-5620.016.patch
>
>
> JIRA proposes to modify the ContainerManager (and other core classes) to 
> support upgrade of a running container with a new {{ContainerLaunchContext}} 
> as well as the ability to rollback the upgrade if the container is not able 
> to restart using the new launch Context. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to