[
https://issues.apache.org/jira/browse/YARN-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526976#comment-15526976
]
Daniel Templeton commented on YARN-4329:
----------------------------------------
Thanks for the patch, [~yufeigu].
* In {{FSAppAttempt.hasContainerForNode()}}, you have {code}if (cond1) {
...
return false;
}
if (cond2) {
...
return false;
}
return true;{code} I'd much rather see {code}boolean ret = true;
if (cond1) {
...
ret = false;
} else if (cond2) {
...
ret = false;
}
return ret;{code}
* Same thing in {{MaxRunningAppsEnforcer.canAppBeRunnable()}}.
* When you're building your message strings, use two appends instead of doing a
string concat inside the append
Love the refactor of {{MaxRunningAppsEnforcer.canAppBeRunnable()}}. Thanks for
making that cleaner.
> Allow fetching exact reason as to why a submitted app is in ACCEPTED state in
> Fair Scheduler
> --------------------------------------------------------------------------------------------
>
> Key: YARN-4329
> URL: https://issues.apache.org/jira/browse/YARN-4329
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler, resourcemanager
> Reporter: Naganarasimha G R
> Assignee: Yufei Gu
> Attachments: YARN-4329.001.patch
>
>
> Similar to YARN-3946, it would be useful to capture possible reason why the
> Application is in accepted state in FairScheduler
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
