[
https://issues.apache.org/jira/browse/YARN-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527599#comment-15527599
]
Subru Krishnan commented on YARN-5384:
--------------------------------------
Thanks [~seanpo03] for the patch.
I looked at it & have a few comments:
* Please use {{PriorityProto}} instead of int directly to be aligned with
rest of YARN APIs.
* Can you elaborate on *Priority* in the API Javadocs, i.e. what defines a
higher priority and how do we deal with it and context with _recurrence_.
* It should be cleaner to add a new {{ReservationDefinition::newInstance}}
that takes in *Priority* to avoid changes in all the test classes.
* What about corresponding documentation for *Priority* ? I am fine if you
want to create a separate JIRA for it.
* I think it makes sense to add priority to
{{ReservationDefinitionPBImpl::toString}}.
> Expose priority in ReservationSystem submission APIs
> ----------------------------------------------------
>
> Key: YARN-5384
> URL: https://issues.apache.org/jira/browse/YARN-5384
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler, fairscheduler, resourcemanager
> Reporter: Sean Po
> Assignee: Sean Po
> Attachments: YARN-5384.v1.patch, YARN-5384.v2.patch,
> YARN-5384.v3.patch
>
>
> YARN-5211 proposes adding support for generalized priorities for reservations
> in the YARN ReservationSystem. This JIRA is a sub-task to track the changes
> needed in ApplicationClientProtocol to accomplish it. Please refer to the
> design doc in the parent JIRA for details.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
